Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform_package_overrides #12380

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Add platform_package_overrides for dconf and avahi in both products/product.yml and tests/product_stability/ubuntu2004.yml

Rationale:

  • The Ubuntu focal is in lack of correct platform_package_overrides variables for dconf and avahi

@alanmcanonical alanmcanonical requested a review from a team as a code owner September 16, 2024 08:54
Copy link

openshift-ci bot commented Sep 16, 2024

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 16, 2024
@dodys dodys self-assigned this Sep 16, 2024
@dodys dodys added the Ubuntu Ubuntu product related. label Sep 16, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12380
This image was built from commit: f4f45ae

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12380

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12380 make deploy-local

Copy link

codeclimate bot commented Sep 16, 2024

Code Climate has analyzed commit f4f45ae and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented Sep 16, 2024

/packit build

@dodys dodys added this to the 0.1.75 milestone Sep 17, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 0529505 into ComplianceAsCode:master Sep 17, 2024
90 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants