Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ism_o profiles for RHEL 10 #12418

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • enable Ansible remediation for network_nmcli_permissions
  • exclude some problematic rules, see comments in the file. Here are some explanations of rules which are not excluded but they are shown as failing:
    • enable_ldap_client - no remediation, but the rule seems quite valid, I consider it as remediated manually
    • audit_rules_unsuccessful_file_modification - no Ansible remediation
    • audit_rules_login_events - no Ansible remediation
    • rsyslog_remote_tls_cacert - no remediation, should be remediated manually
    • network_ipv6_static_address - should be remediated manually

Rationale:

  • update of profiles for RHEL 10

Review Hints:

  • run automatus in profile mode against RHEL 10 machine

@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Sep 25, 2024
@vojtapolasek vojtapolasek added this to the 0.1.75 milestone Sep 25, 2024
@vojtapolasek vojtapolasek requested a review from a team as a code owner September 25, 2024 08:08
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12418
This image was built from commit: 1fefa5a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12418

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12418 make deploy-local

Copy link

codeclimate bot commented Sep 25, 2024

Code Climate has analyzed commit 1fefa5a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Sep 26, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @vojtapolasek

@marcusburghardt marcusburghardt merged commit 11e6416 into ComplianceAsCode:master Sep 26, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants