Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RH references for OL #12593

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

mrkanon
Copy link
Contributor

@mrkanon mrkanon commented Nov 8, 2024

Description:

  • Update fapolicy_default_deny ansible and bash remediations
  • Update package_libreport-plugin-logger_removed rule

Rationale:

Fix references for OL

Update fapolicy_default_deny and libreport-plugin rules to
omit RH references in OL build

Signed-off-by: Armando Acosta <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 8, 2024
Copy link

openshift-ci bot commented Nov 8, 2024

Hi @mrkanon. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Nov 8, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 8, 2024

Code Climate has analyzed commit 449525c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Nov 11, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Nov 11, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879
Copy link
Member

Mab879 commented Nov 11, 2024

Waving automatus as these changes are prose only.

@Mab879 Mab879 merged commit a1b1ffd into ComplianceAsCode:master Nov 11, 2024
91 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants