Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oval_feed_url for Ubuntu #12617

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 18, 2024

Description:

Replace outdated broken links with current feeds from
https://security-metadata.canonical.com/oval/
@mpurg mpurg requested a review from a team as a code owner November 18, 2024 08:54
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 18, 2024
Copy link

openshift-ci bot commented Nov 18, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mpurg
Copy link
Contributor Author

mpurg commented Nov 18, 2024

I found after the fact that these PRs were opened to address the same issue:

Since they are not complete (test stability, broken ctest) and could be improved (using USN vs CVE feeds), I'll leave this PR open for now.

The ctest verify-references-ssg-*-ds.xml failed
after changing oval_feed_url to point to new urls,
due to too many oval references in datastream.

Reason was the the new name of the OVAL feed
was no longer excluded in verify_references.py and
was considered as a regular OVAL file.
Copy link

codeclimate bot commented Nov 18, 2024

Code Climate has analyzed commit ca52b77 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Nov 18, 2024
@dodys dodys added the Ubuntu Ubuntu product related. label Nov 18, 2024
@dodys dodys added this to the 0.1.76 milestone Nov 18, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 444895f into ComplianceAsCode:master Nov 18, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants