Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several controls and variables for Ubuntu 24.04 CIS #12624

Merged
merged 16 commits into from
Nov 25, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 21, 2024

Description:

Update several controls for Ubuntu 24.04 CIS, adding missing rules and fixing variable overrides:

  • 2.1.2 - Ensure avahi daemon services are not in use
  • 2.1.4 - Ensure dns server services are not in use
  • 2.1.6 - Ensure ftp server services are not in use
  • 2.1.7 - Ensure ldap server services are not in use
  • 2.1.8 - Ensure message access server services are not in use
  • 2.1.9 - Ensure network file system services are not in use
  • 2.1.10 - Ensure nis server services are not in use
  • 2.1.11 - Ensure print server services are not in use
  • 2.1.12 - Ensure rpcbind services are not in use
  • 2.1.13 - Ensure rsync services are not in use
  • 2.1.14 - Ensure samba file server services are not in use
  • 2.1.15 - Ensure snmp services are not in use
  • 2.1.16 - Ensure tftp server services are not in use
  • 2.1.17 - Ensure web proxy server services are not in use
  • 2.1.19 - Ensure xinetd services are not in use
  • 2.1.20 - Ensure X window server services are not in use

@mpurg mpurg marked this pull request as draft November 21, 2024 09:25
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Nov 21, 2024
Copy link

openshift-ci bot commented Nov 21, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mpurg mpurg changed the title Update Ubuntu2404 CIS 2.x controls and variables Update several controls and variables for Ubuntu 24.04 CIS Nov 21, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mpurg mpurg force-pushed the ubuntu2404_cis_services branch from 0ad3274 to f9d3661 Compare November 21, 2024 09:41
@mpurg mpurg marked this pull request as ready for review November 21, 2024 09:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 21, 2024
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_service_slapd_disabled'.
--- xccdf_org.ssgproject.content_rule_service_slapd_disabled
+++ xccdf_org.ssgproject.content_rule_service_slapd_disabled
@@ -3,11 +3,12 @@
 Disable LDAP Server (slapd)
 
 [description]:
-The Lightweight Directory Access Protocol (LDAP) is a service that provides a method for looking up information from a central database.
+The Lightweight Directory Access Protocol (LDAP) is a service that
+provides a method for looking up information from a central database.
 
 [rationale]:
-If the system will not need to act as an LDAP server, it is recommended that the software be
-disabled to reduce the potential attack surface.
+If the system will not need to act as an LDAP server, it is recommended
+that the software be disabled to reduce the potential attack surface.
 
 [ident]:
 CCE-87262-2

Copy link

codeclimate bot commented Nov 21, 2024

Code Climate has analyzed commit f9d3661 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys requested a review from a team November 25, 2024 12:12
@dodys dodys self-assigned this Nov 25, 2024
@dodys dodys added the Ubuntu Ubuntu product related. label Nov 25, 2024
@dodys dodys added CIS CIS Benchmark related. Update Profile Issues or pull requests related to Profiles updates. labels Nov 25, 2024
@dodys dodys added this to the 0.1.76 milestone Nov 25, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit aa31e28 into ComplianceAsCode:master Nov 25, 2024
92 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants