Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamps for data-stream composition #12625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ggbecker
Copy link
Member

Description:

  • Unify and use the constant timestamp across the whole code.

  • Previously oscap info command would print null for such cases. Stream: scap_org.open-scap_datastream_from_xccdf_ssg-fedora-xccdf.xml Generated: (null)

Review Hints:

  • oscap info "ds.file"

Previous:
~ 0 $ oscap info "/usr/share/xml/scap/ssg/content/ssg-fedora-ds.xml"
Document type: Source Data Stream
Imported: 2024-08-12T02:00:00

Stream: scap_org.open-scap_datastream_from_xccdf_ssg-fedora-xccdf.xml
Generated: (null)
Version: 1.3
Checklists:

Current:
oscap info build/ssg-rhel9-ds.xml
Document type: Source Data Stream
Imported: 2024-11-21T14:20:20

Stream: scap_org.open-scap_datastream_from_xccdf_ssg-rhel9-xccdf.xml
Generated: 2024-11-21T13:20:19
Version: 1.3
Checklists:

Unify and use the constant timestamp across the whole code.

Previously oscap info command would print null for such cases.
Stream: scap_org.open-scap_datastream_from_xccdf_ssg-fedora-xccdf.xml
Generated: (null)
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 21, 2024

Code Climate has analyzed commit c6da20a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@ggbecker ggbecker added this to the 0.1.76 milestone Nov 22, 2024
@jan-cerny jan-cerny changed the title Fix timestamps for data-stream composition. Fix timestamps for data-stream composition Nov 26, 2024
@jan-cerny jan-cerny self-assigned this Nov 28, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggbecker What do you think about the date attribute of the status element within the Benchmark element? I think this one should be changed as well because it depends on the current date. See build_yaml.py line 426.

@jan-cerny
Copy link
Collaborator

@ggbecker What is your opinion on the comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants