Update ensure_logrotate_activated for image mode #12645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule will be reworked to work well during a bootable container image build. First, the OVAL will use an internal check for the logrotate timer instead of extend_definition which uses OVAL systemdunitproperty test which doesn't work in that environment. Second, we will installed crontabs package to make sure that the files required by the bash remediation are present.
jan-cerny
added
OVAL
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffbash remediation for rule 'xccdf_org.ssgproject.content_rule_ensure_logrotate_activated' differs.
--- xccdf_org.ssgproject.content_rule_ensure_logrotate_activated
+++ xccdf_org.ssgproject.content_rule_ensure_logrotate_activated
@@ -3,6 +3,9 @@
LOGROTATE_CONF_FILE="/etc/logrotate.conf"
+if ! rpm -q --quiet "crontabs" ; then
+ yum install -y "crontabs"
+fi
CRON_DAILY_LOGROTATE_FILE="/etc/cron.daily/logrotate"
|
Mab879
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule will be reworked to work well during a bootable container image build. First, the OVAL will use an internal check for the logrotate timer instead of extend_definition which uses OVAL systemdunitproperty test which doesn't work in that environment. Second, we will installed crontabs package to make sure that the files required by the bash remediation are present.