Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Ubuntu oval and remediation for nftables_rules_permanent" #12649

Merged

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 28, 2024

Reverts #12643

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 28, 2024
Copy link

openshift-ci bot commented Nov 28, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle15 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys requested a review from a team November 28, 2024 14:07
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
Platform has been changed for rule 'xccdf_org.ssgproject.content_rule_nftables_rules_permanent'
--- xccdf_org.ssgproject.content_rule_nftables_rules_permanent
+++ xccdf_org.ssgproject.content_rule_nftables_rules_permanent
@@ -1,3 +1,2 @@
 oval:ssg-package_nftables:def:1
 oval:ssg-service_disabled_firewalld:def:1
-oval:ssg-service_disabled_ufw:def:1

@dodys dodys self-assigned this Nov 28, 2024
@dodys dodys added the Ubuntu Ubuntu product related. label Nov 28, 2024
Copy link

codeclimate bot commented Nov 28, 2024

Code Climate has analyzed commit 5f7778e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys added this to the 0.1.76 milestone Nov 28, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dodys dodys merged commit 61cec28 into ComplianceAsCode:master Nov 29, 2024
90 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants