Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsyslog package applicability to ensure_rsyslog_log_file_configuration group #12650

Merged

Conversation

matusmarhefka
Copy link
Member

Add rsyslog to templated package applicability platforms and use it in the ensure_rsyslog_log_file_configuration group to make all the rules in the group applicable only in case rsyslog package is installed.

@matusmarhefka matusmarhefka added the Image Mode Bootable containers and Image Mode RHEL label Nov 28, 2024
@matusmarhefka matusmarhefka added this to the 0.1.76 milestone Nov 28, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 28, 2024

Code Climate has analyzed commit 7fdffa4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Nov 29, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the rules rsyslog_files_groupownership, rsyslog_files_ownership, rsyslog_files_permissions are using the new package_rsyslog platform. I have tested that when building a CS 9 bootable container image with the CIS server L2 profile these rules are notapplicable both during the build and in the verification scan.

@jan-cerny jan-cerny merged commit 6c8c2c8 into ComplianceAsCode:master Nov 29, 2024
104 of 106 checks passed
@matusmarhefka matusmarhefka deleted the rsyslog_conf_package_platform branch December 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Image Mode Bootable containers and Image Mode RHEL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants