Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up Opensc Rules in RHEL 10 #12738

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Clean Up Opensc Rules in RHEL 10 #12738

merged 2 commits into from
Dec 18, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 18, 2024

Description:

  • Remove force_opensc_card_drivers from RHEL 10
  • Add new rule package_pcsc-lite-ccid_installed

Rationale:

Prep for RHEL 10

@Mab879 Mab879 added New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Dec 18, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Dec 18, 2024
@Mab879 Mab879 requested a review from a team as a code owner December 18, 2024 00:13
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ol8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 18, 2024

Code Climate has analyzed commit f2bf77b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Dec 18, 2024
jan-cerny
jan-cerny approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built RHEL 10 data stream, The rule force_opensc_card_drivers isn't present there. The rule package_pcsc-lite-ccid_installed is present there and is a part of RHEL 10 ISM and STIG profiles.

@jan-cerny jan-cerny merged commit b8d7a76 into ComplianceAsCode:master Dec 18, 2024
98 of 105 checks passed
@Mab879 Mab879 deleted the clean_up_opensc_rules_rhel10 branch December 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
New Rule Issues or pull requests related to new Rules. RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@Mab879 @jan-cerny