Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reg error in 10-bash.jinjia #12775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xcfxr
Copy link

@xcfxr xcfxr commented Jan 3, 2025

sed -i use Basic Regular Expression(BRE), so it needs to use Escape character when using character like ')', '?', '+' and so on. I see it may be forgot here. There is another question here. After modifying /etc/default/grub, grub2-mkconfig is not used to make it effective, so the modification is meaningless. Should I directly modify /etc/grub2.cfg (x86) or /etc/grub2-efi/cfg?

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 3, 2025
Copy link

openshift-ci bot commented Jan 3, 2025

Hi @xcfxr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 3, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant