Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accounts_password_pam_retry for RHEL 10 #12783

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 7, 2025

Description:

Update accounts_password_pam_retry for RHEL 10.

Rationale:

Fixes #12768

Review Hints:

./automatus.py rule --datastream ../build/ssg-rhel10-ds.xml --libvirt qemu:///system automatus_rhel10 --remediate-using ansible accounts_password_pam_retry

@Mab879 Mab879 added Update Rule Issues or pull requests related to Rules updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Jan 7, 2025
@Mab879 Mab879 added this to the 0.1.76 milestone Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 7, 2025

Code Climate has analyzed commit 9d32548 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Jan 9, 2025
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@vojtapolasek
Copy link
Collaborator

I waive failing tests.
SLE: there is no Ansible remediation for the rule, the SLE is not mentioned in the list of platforms. Out of scope for this PR.
Ubuntu: The rule is not present in the benchmark.
RHEL8 UBI: The authselect package is not present in the container and can't be installed.
Ubuntu ctest/oscal fail: not relevant to this PR
Kubernetes fail: failing after multiple reruns, I don't think it is relevant to this PR.

@vojtapolasek vojtapolasek merged commit 71c2f9b into ComplianceAsCode:master Jan 9, 2025
101 of 107 checks passed
@Mab879 Mab879 deleted the fix_accounts_password_pam_retry branch January 9, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule accounts_password_pam_retry fails after ansible remediaton
2 participants