Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in processing profile selections #12792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qduanmu
Copy link

@qduanmu qduanmu commented Jan 9, 2025

Description:

Fix the TypeError: 'NoneType' object is not iterable when processing profile selections

Review Hints:

Some profiles has no 'selections' but just a 'extends'. e.g., ocp4/profiles/pci-dss-node.profile

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

Hi @qduanmu. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jan 9, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qduanmu qduanmu force-pushed the fix-ssg-variables branch from 2a96ca1 to ed3742e Compare January 9, 2025 02:47
@marcusburghardt marcusburghardt self-assigned this Jan 9, 2025
@marcusburghardt marcusburghardt added the Infrastructure Our content build system label Jan 9, 2025
Copy link

codeclimate bot commented Jan 9, 2025

Code Climate has analyzed commit ed3742e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.76 milestone Jan 9, 2025
@marcusburghardt
Copy link
Member

@qduanmu , thank you very much for catching this issue and promptly providing a fix. In the meantime I was working on #12797 and incorporated your fix here 43a9395 . Is that ok for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants