fix: Return GrantAlreadyExists annotation
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
force-pushed
the
marcos/ref/config-schema
branch
from
71520da
to
6cd3354
Compare
mgaeta
force-pushed
the
marcos/fix/grant-already-exists-3
branch
from
3aa1802
to
2737551
Compare
mgaeta
force-pushed
the
marcos/ref/config-schema
branch
2 times, most recently
from
08ad3fb
to
cf8a971
Compare
mgaeta
force-pushed
the
marcos/fix/grant-already-exists-3
branch
from
2737551
to
dd68baf
Compare
mgaeta
force-pushed
the
marcos/ref/config-schema
branch
from
cf8a971
to
a58b4bb
Compare
ggreer
reviewed
Aug 27, 2024
cmd/baton-aws/config_test.go
Outdated
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/conductorone/baton-sdk/pkg/test" |
There was a problem hiding this comment.
I think you need to go mod tidy && go mod vendor to fix this.
mgaeta
force-pushed
the
marcos/fix/grant-already-exists-3
branch
from
dd68baf
to
adba34a
Compare
ggreer
approved these changes
Aug 28, 2024
ggreer
pushed a commit
that referenced
this pull request
Aug 28, 2024
* lint long lines * Use new config schema * Update README * go mod * add unit tests * clean up CI warnings * fix: Return `GrantAlreadyExists` annotation (#55) * add new annotation * move resource types to a file * Moke identity store client an interface * add unit tests * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the previous hotfix, we returned a empty grant list when Grant was called and the entitlement already existed.
This PR uses the newly created
GrantAlreadyExistsmessage as an outputted annotation.TODO
go.mod.