Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resources to baton-vgs #1

Merged
merged 15 commits into from
Apr 10, 2024
Merged

Adding resources to baton-vgs #1

merged 15 commits into from
Apr 10, 2024

Conversation

mchavez
Copy link
Collaborator

@mchavez mchavez commented Mar 15, 2024

  • Add docker-compose file
  • Add VGS client

Copy link
Contributor

@ggreer ggreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this PR, but clean up the http & url handing in a new PR. The baton SDK has quite a few helpers that we can take advantage of.


func (v *VGSClient) GetOrganizationUsers(ctx context.Context, orgId string) ([]OrganizationUser, error) {
v.InitHttpClient()
req, err := http.NewRequestWithContext(ctx, http.MethodGet, v.endpoint+"/"+orgId+"/users", nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use url.joinpath here. Or even better: use the baton uhttp helpers.

@ggreer ggreer marked this pull request as ready for review April 10, 2024 20:07
@ggreer ggreer merged commit cd827f6 into main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants