Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VGS Resources #8

Merged
merged 44 commits into from
May 8, 2024
Merged

Adding VGS Resources #8

merged 44 commits into from
May 8, 2024

Conversation

mchavez
Copy link
Collaborator

@mchavez mchavez commented Apr 18, 2024 •
edited
Loading

  • Listing Users
  • Listing Organizations
  • Listing Vaults

@mchavez mchavez changed the title Refactoring client Listing users Apr 19, 2024
@mchavez mchavez changed the title Listing users Adding Resources Apr 19, 2024
@mchavez mchavez marked this pull request as ready for review April 24, 2024 15:52
@mchavez mchavez requested review from ggreer and jirwin April 24, 2024 21:59
@mchavez mchavez changed the title Adding Resources Adding VGS Resources Apr 26, 2024
ggreer
ggreer approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@ggreer ggreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small issues but this is better than what's in master. Feel free to merge it. If you want to tweak a few things and then merge it, that's also fine.

pkg/client/client.go Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
pkg/connector/vault.go Outdated Show resolved Hide resolved
@ggreer ggreer merged commit 8d42d63 into main May 8, 2024
3 checks passed
@ggreer ggreer deleted the mchavez-baton-vgs branch May 8, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreer ggreer ggreer approved these changes

@jirwin jirwin Awaiting requested review from jirwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchavez @ggreer