Anthony/add expanders #63
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquerna
reviewed
Mar 19, 2024
tools/expander.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| atTypeApp = "type.googleapis.com/c1.api.app.v1.App" |
There was a problem hiding this comment.
do we export these const from the SDK anywhere? shouldn't we?
pquerna
reviewed
Mar 19, 2024
| } | ||
|
|
||
| // Use reflection to call the `GetAtType` method on an pointer receiver, func GetAtType() *string. | ||
| func GetAtTypeWithReflection[T any](input *T) *string { |
There was a problem hiding this comment.
can't this be T getAtType with type getAtType interface{ GetAtType() *string }?
There was a problem hiding this comment.
I get this error type *T is pointer to type parameter, not type parameter because:
The method set of *T does not automatically include pointer receiver methods declared on the T's concrete type A, and it does not implement interfaces that would be implemented by *A.
I cant think of a better way of doing this since I am doing this weird thing where I call both a pointer receiver function and a normal function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hold for now
I made the expander code in the cone repo into a tools package for the go sdk. I used a more idiomatic way of representing generics and reflection to eliminate some of the boiler plate required.