Test fixes

[neumachen]

Fixed the failing error test. I believe it's best to create the modules for raising exceptions outside and calling them. Will probably do that later on.

Also since the RSpec dependency is not restricted to a version I updated the syntax of the test to match the RSpec 3+ syntax methods.

All tests pass, the only thing that was really changed or modified to pass was the commands_spec.rb.

[neumachen]

It keeps failing on the rbx build. Will investigate this further.

[unfunco]

@magicalbanana Did you get any further with the failing rbx builds? I could take a look at it sometime this week if that's any help?

@ConradIrwin Can we push for a new release if the tests above pass on rbx? This is currently holding up a release of pry. See pry/pry#1448 for more information.

[neumachen]

@unfunco never did. Did not find time, but maybe next week or so I can build a box that has rbx built in it and try and see if I can fix it.

[neumachen]

I think we should just drop support for rbx.

[ConradIrwin]

@magicalbanana This creates a new global constant, which you almost certainly don't want to do (it will leak between tests). If you need to extend the scope of the variable use a local that's set to nil at the start of the test. Same applies everywhere you are rescuing into a constant.

[ConradIrwin]

Happy to drop rbx. This can be merged when there are no warnings during test runs (mostly due to rescuing constants).

Sorry for the long lead time on this.

[neumachen]

Yeah, thanks for dropping rbx. It would be better if we did, I mean I really do not know anyone who uses rbx, would've been nice if we could make it work though.

[joallard]

Can this still be used? I see some stuff that might be useful here