Remove global icon imports #437
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 2, 2019 14:04
…e.json. Point module property value in package.json to /dist/es directory. Updated demo app to allow for production bundle analysis. Tree shaking works when building es modules manually via babel command line.
…nd babel (for ES6).
… rimble components to inherit.
# Conflicts: # demo/package.json # demo/yarn.lock # package.json # yarn.lock
…import. Update tests.
|
Deploy preview for rimble-ui-storybook ready! Built with commit 46e9798 |
added 2 commits
February 25, 2020 12:27
# Conflicts: # demo/src/App.js # package.json # src/Button/BaseButton.js # src/Button/__snapshots__/Button.test.js.snap # src/Checkbox/__snapshots__/Checkbox.test.js.snap # src/Checkbox/index.js # src/EthAddress/__snapshots__/EthAddress.test.js.snap # src/Form/__snapshots__/form.test.js.snap # src/Icon/__snapshots__/Icon.test.js.snap # src/Input/__snapshots__/FileInput.test.js.snap # src/Input/index.js # src/Radio/__snapshots__/Radio.test.js.snap # src/Radio/index.js # src/Select/__snapshots__/Select.test.js.snap # src/ToastMessage/__snapshots__/ToastMessage.test.js.snap # src/Tooltip/__snapshots__/Tooltip.test.js.snap # src/index.js # yarn.lock
Add babel-only build step
# Conflicts: # demo/src/App.js # demo/yarn.lock # package.json # src/Button/__snapshots__/Button.test.js.snap # src/Checkbox/index.js # src/EthAddress/__snapshots__/EthAddress.test.js.snap # src/Icon/__snapshots__/Icon.test.js.snap # src/Icon/index.js # src/Input/__snapshots__/FileInput.test.js.snap # src/Input/index.js # src/Radio/index.js # src/Select/__snapshots__/Select.test.js.snap # src/Select/index.js # src/ToastMessage/__snapshots__/ToastMessage.test.js.snap # src/Tooltip/__snapshots__/Tooltip.test.js.snap # yarn.lock
|
Any news? This is important for an app my company is working on. |
geoknee
added a commit
to statechannels/statechannels
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entire rimble-ui library is now tree-shakeable. Icons are separated to a new repo.
Before: (rimble-ui + dependencies size ~1.89MB)
After: (rimble-ui + dependencies size ~300KB)
Fixes #436