fix: sis doesn't use twiddles directly no more

Consensys · Dec 15, 2023 · 7ef61c9 · 7ef61c9
1 parent 8cda879
commit 7ef61c9
Show file tree

Hide file tree

Showing 8 changed files with 326 additions and 176 deletions.
diff --git a/ecc/bls12-377/fr/sis/sis.go b/ecc/bls12-377/fr/sis/sis.go
@@ -119,7 +119,7 @@ func NewRSis(seed int64, logTwoDegree, logTwoBound, maxNbElementsToHash int) (*R
 		LogTwoBound:         logTwoBound,
 		capacity:            capacity,
 		Degree:              degree,
-		Domain:              fft.NewDomain(uint64(degree), shift),
+		Domain:              fft.NewDomain(uint64(degree), fft.WithShift(shift)),
 		A:                   make([][]fr.Element, n),
 		Ag:                  make([][]fr.Element, n),
 		bufM:                make(fr.Vector, degree*n),
@@ -129,7 +129,7 @@ func NewRSis(seed int64, logTwoDegree, logTwoBound, maxNbElementsToHash int) (*R
 	}
 	if r.LogTwoBound == 8 && r.Degree == 64 {
 		// TODO @gbotrel fixme, that's dirty.
-		r.twiddleCosets = precomputeTwiddlesCoset(r.Domain.Twiddles, r.Domain.FrMultiplicativeGen)
+		r.twiddleCosets = precomputeTwiddlesCoset(r.Domain.Generator, r.Domain.FrMultiplicativeGen)
 	}
 
 	// filling A

diff --git a/ecc/bls12-377/fr/sis/sis_fft.go b/ecc/bls12-377/fr/sis/sis_fft.go
diff --git a/ecc/bls12-377/fr/sis/sis_test.go b/ecc/bls12-377/fr/sis/sis_test.go
@@ -142,7 +142,7 @@ func TestMulMod(t *testing.T) {
 	// and random.
 	var shift fr.Element
 	shift.SetString("19540430494807482326159819597004422086093766032135589407132600596362845576832")
-	domain := fft.NewDomain(uint64(size), shift)
+	domain := fft.NewDomain(uint64(size), fft.WithShift(shift))
 
 	// mul mod
 	domain.FFT(p, fft.DIF, fft.OnCoset())
@@ -415,7 +415,7 @@ func TestUnrolledFFT(t *testing.T) {
 
 	const size = 64
 	assert := require.New(t)
-	domain := fft.NewDomain(size, shift)
+	domain := fft.NewDomain(size, fft.WithShift(shift))
 
 	k1 := make([]fr.Element, size)
 	for i := 0; i < size; i++ {
@@ -428,7 +428,7 @@ func TestUnrolledFFT(t *testing.T) {
 	domain.FFT(k1, fft.DIF, fft.OnCoset(), fft.WithNbTasks(1))
 
 	// unrolled FFT
-	twiddlesCoset := precomputeTwiddlesCoset(domain.Twiddles, domain.FrMultiplicativeGen)
+	twiddlesCoset := precomputeTwiddlesCoset(domain.Generator, domain.FrMultiplicativeGen)
 	fft64(k2, twiddlesCoset)
 
 	// compare results

diff --git a/ecc/bn254/fr/sis/sis.go b/ecc/bn254/fr/sis/sis.go
@@ -129,7 +129,7 @@ func NewRSis(seed int64, logTwoDegree, logTwoBound, maxNbElementsToHash int) (*R
 	}
 	if r.LogTwoBound == 8 && r.Degree == 64 {
 		// TODO @gbotrel fixme, that's dirty.
-		r.twiddleCosets = precomputeTwiddlesCoset(r.Domain.Twiddles, r.Domain.FrMultiplicativeGen)
+		r.twiddleCosets = precomputeTwiddlesCoset(r.Domain.Generator, r.Domain.FrMultiplicativeGen)
 	}
 
 	// filling A