fix: raise error when nbDigest != number of polynomials

Consensys · Sep 18, 2024 · b4815d6 · b4815d6
1 parent d207428
commit b4815d6
Show file tree

Hide file tree

Showing 10 changed files with 58 additions and 18 deletions.
diff --git a/ecc/bls12-377/shplonk/shplonk.go b/ecc/bls12-377/shplonk/shplonk.go
diff --git a/ecc/bls12-378/shplonk/shplonk.go b/ecc/bls12-378/shplonk/shplonk.go
diff --git a/ecc/bls12-381/shplonk/shplonk.go b/ecc/bls12-381/shplonk/shplonk.go
diff --git a/ecc/bls24-315/shplonk/shplonk.go b/ecc/bls24-315/shplonk/shplonk.go
diff --git a/ecc/bls24-317/shplonk/shplonk.go b/ecc/bls24-317/shplonk/shplonk.go
diff --git a/ecc/bn254/shplonk/shplonk.go b/ecc/bn254/shplonk/shplonk.go
diff --git a/ecc/bw6-633/shplonk/shplonk.go b/ecc/bw6-633/shplonk/shplonk.go
diff --git a/ecc/bw6-756/shplonk/shplonk.go b/ecc/bw6-756/shplonk/shplonk.go
diff --git a/ecc/bw6-761/shplonk/shplonk.go b/ecc/bw6-761/shplonk/shplonk.go
diff --git a/internal/generator/shplonk/template/shplonk.go.tmpl b/internal/generator/shplonk/template/shplonk.go.tmpl
@@ -13,6 +13,7 @@ import (
 var (
 	ErrInvalidNumberOfPoints = errors.New("number of digests should be equal to the number of points")
 	ErrVerifyOpeningProof    = errors.New("can't verify batch opening proof")
+	ErrInvalidNumberOfDigests = errors.New("number of digests should be equal to the number of polynomials")
 )
 
 // OpeningProof KZG proof for opening (fᵢ)_{i} at a different points (xᵢ)_{i}.
@@ -40,6 +41,9 @@ func BatchOpen(polynomials [][]fr.Element, digests []kzg.Digest, points [][]fr.E
 	if len(polynomials) != len(points) {
 		return res, ErrInvalidNumberOfPoints
 	}
+	if len(polynomials) != len(digests) {
+		return res, ErrInvalidNumberOfDigests
+	}
 
 	// transcript
 	fs := fiatshamir.NewTranscript(hf, "gamma", "z")