Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSigma -> GSigmaNeg #548

Merged
merged 2 commits into from
Oct 10, 2024
Merged

GSigma -> GSigmaNeg #548

merged 2 commits into from
Oct 10, 2024

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Oct 2, 2024

Description

This PR changes a variable's name to reflect its content more accurately.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Tabaie Tabaie requested a review from ivokub October 4, 2024 17:49
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PS - I created corresponding gnark PR Consensys/gnark#1295. After merging this PR you can update the gnark-crypto dependency there and also merge that one so that we don't suddenly have broken builds.

@Tabaie Tabaie merged commit 6638408 into master Oct 10, 2024
5 checks passed
@Tabaie Tabaie deleted the docs/pedersen branch October 10, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants