Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use golint option to include generated files #549

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Oct 4, 2024

Description

There is now option to also lint generated files: golangci/golangci-lint#4740

This PR configures the linter and omits the editing of files in CI to have reproducible results when run locally outside of CI.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the cleanup Suggestion to clean up the code label Oct 4, 2024
@ivokub ivokub requested a review from gbotrel October 4, 2024 11:39
@ivokub ivokub self-assigned this Oct 4, 2024
@ivokub ivokub merged commit a357b13 into master Oct 4, 2024
5 checks passed
@ivokub ivokub deleted the chore/lint-generated branch October 4, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Suggestion to clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants