feat: Accounting for Spillage #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the system to enable correct accounting of spillage. At this stage, there remains an outstanding problem related to the handling of sorted permutations. In particular, the padding values are not determined correctly. The issue seems to be that, for a negative permutation sort, we actually want to pad at the back (i.e. not the front). I think the next step is to investigage what Corset does. Perhaps this is actually where it uses back padding.
This puts in place a partial fix for the spillage issue. The intuition here is that we have a sign for padding, and that padding can happen on the front or the back. However, at the moment, it is broken because when padding is applied the height of the trace is not being updated. The best solution will be to add a method `Pad()` to `Trace` which accepts an iterator over the signs of the column. This can be used to properly pad the columns in one go.
This fixes the padding API to use an iterator, and removes the `InsertFront` method which is now subsumed. The remaining step is to actually maintain a padding direction for each column.
DavePearce
changed the title
There are some genuinely hard problems with negative permutation sorts. The current solution is simply to prohibit permutation sorts whose "index column" (i.e. leftmost column) is negatively sorted. There is an additional issue that traces which have a `0` for this column prior to expansion will (most likely) be rejected.
DavePearce
force-pushed
the
117-feat-accounting-for-spillage
branch
from
953de6b
to
e0bdd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.