Support Non-Strict Trace Checking #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a small (but important) change to the alignment algorithm. Specifically, it no longer reports an error if there are unknown columns in the trace. Instead, the caller is responsible for checking this and reacting accordingly. This enables the caller to continue if it so wishes.
This adds the ability to override the default and reduce the level of strictness when it comes to unknown columns in the trace. Specifically, with `--warn` the tool will continue with a warning when an unknown trace column is encountered.
This tidies up the check command and improves the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
checkcommand to support a command-line flag--warnwhich allows checking to continue even in the presence of unknown trace columns. Such columns are safe to ignore, since they aren't used in the schema. Furthermore, in practice cases, we are often running against traces which have more columns than the given schema (e.g. because some parts of the schema are commented out, etc).