Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance TracesFilesManager test coverage #137

Merged
merged 3 commits into from
Oct 16, 2024
Merged

enhance TracesFilesManager test coverage #137

merged 3 commits into from
Oct 16, 2024

Conversation

nadeemb53
Copy link
Contributor

@nadeemb53 nadeemb53 commented Oct 4, 2024 •
edited
Loading

This PR improves test coverage

  • Add initialization test for nonCanonicalTracesDir creation
  • Add file movement verification test
  • Add case sensitivity handling test
  • Add edge case test for short polling intervals
  • Fix BigInt literal usage in LineaRollup test

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

jpnovais
jpnovais approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@jpnovais jpnovais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :)

@julien-marchand julien-marchand merged commit 946b0ef into Consensys:main Oct 16, 2024
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnovais jpnovais jpnovais approved these changes

@julien-marchand julien-marchand julien-marchand approved these changes

@Filter94 Filter94 Awaiting requested review from Filter94

@gauravahuja gauravahuja Awaiting requested review from gauravahuja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadeemb53 @jpnovais @julien-marchand @VGau