Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite error logs from blob submission eth_call due to insuffi… #157

Merged

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Oct 7, 2024

…cient gas prices

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho self-assigned this Oct 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.41%. Comparing base (8861b6d) to head (b8379b6).

Files with missing lines Patch % Lines
...nsensys/zkevm/ethereum/submission/LoggingHelper.kt 83.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #157      +/-   ##
============================================
- Coverage     70.54%   70.41%   -0.13%     
+ Complexity     1042     1041       -1     
============================================
  Files           282      282              
  Lines         11310    11328      +18     
  Branches       1080     1087       +7     
============================================
- Hits           7979     7977       -2     
- Misses         2861     2879      +18     
- Partials        470      472       +2     
Flag Coverage Δ *Carryforward flag
hardhat 98.69% <ø> (ø) Carriedforward from 0fc4bc7
kotlin 67.91% <83.33%> (-0.14%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...nsensys/zkevm/ethereum/submission/LoggingHelper.kt 63.63% <83.33%> (-9.70%) ⬇️

... and 5 files with indirect coverage changes

@jonesho jonesho requested a review from jpnovais October 9, 2024 09:39
@jonesho
Copy link
Contributor Author

jonesho commented Oct 16, 2024

@jpnovais see if you could review this again for the changes based on your previous comments

@jonesho jonesho force-pushed the feat/better-log-message-for-l1-dynamic-gas-pricing-eth_call-error branch from 97c12f9 to 0fc4bc7 Compare October 17, 2024 13:07
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 17, 2024 13:08 — with GitHub Actions Inactive
@jonesho jonesho requested a review from jpnovais October 17, 2024 14:05
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 17, 2024 15:18 — with GitHub Actions Inactive
@jonesho jonesho merged commit 4e1e2a5 into main Oct 17, 2024
22 checks passed
@jonesho jonesho deleted the feat/better-log-message-for-l1-dynamic-gas-pricing-eth_call-error branch October 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants