-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite error logs from blob submission eth_call due to insuffi… #157
Merged
jonesho
merged 7 commits into
main
from
feat/better-log-message-for-l1-dynamic-gas-pricing-eth_call-error
Oct 17, 2024
Merged
feat: rewrite error logs from blob submission eth_call due to insuffi… #157
jonesho
merged 7 commits into
main
from
feat/better-log-message-for-l1-dynamic-gas-pricing-eth_call-error
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
============================================
- Coverage 70.54% 70.41% -0.13%
+ Complexity 1042 1041 -1
============================================
Files 282 282
Lines 11310 11328 +18
Branches 1080 1087 +7
============================================
- Hits 7979 7977 -2
- Misses 2861 2879 +18
- Partials 470 472 +2
*This pull request uses carry forward flags. Click here to find out more.
|
jpnovais
reviewed
Oct 8, 2024
.../blob-submitter/src/test/kotlin/net/consensys/zkevm/ethereum/submission/LoggingHelperTest.kt
Outdated
Show resolved
Hide resolved
@jpnovais see if you could review this again for the changes based on your previous comments |
jpnovais
reviewed
Oct 16, 2024
...reum/blob-submitter/src/main/kotlin/net/consensys/zkevm/ethereum/submission/LoggingHelper.kt
Outdated
Show resolved
Hide resolved
.../blob-submitter/src/test/kotlin/net/consensys/zkevm/ethereum/submission/LoggingHelperTest.kt
Outdated
Show resolved
Hide resolved
…price during blob submission eth_call
…pdate rewrite wordings
jonesho
force-pushed
the
feat/better-log-message-for-l1-dynamic-gas-pricing-eth_call-error
branch
from
October 17, 2024 13:07
97c12f9
to
0fc4bc7
Compare
jonesho
temporarily deployed
to
docker-build-and-e2e
October 17, 2024 13:08
— with
GitHub Actions
Inactive
jpnovais
approved these changes
Oct 17, 2024
…ricing-eth_call-error
jonesho
temporarily deployed
to
docker-build-and-e2e
October 17, 2024 15:18
— with
GitHub Actions
Inactive
bradbown
approved these changes
Oct 17, 2024
jonesho
deleted the
feat/better-log-message-for-l1-dynamic-gas-pricing-eth_call-error
branch
October 17, 2024 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cient gas prices
This PR implements issue(s) #
Checklist