Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: bump go-corset to the latest version #160

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Conversation

gusiri
Copy link
Contributor

@gusiri gusiri commented Oct 8, 2024

This PR

  • bumps go-corset to the latest commit as this fixes some performance issues exposed by this bug 82f81b5.
  • fixes compile error with the latest go-corset (String() undefined)
zkevm/arithmetization/definition.go:90:20: corsetCS.String undefined (type "github.com/consensys/go-corset/pkg/schema".Constraint has no field or method String)
zkevm/arithmetization/definition.go:234:57: e.String undefined (type air.Expr has no field or method String)

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@gusiri gusiri changed the title chore: bump go-corset to the latest version Prover: bump go-corset to the latest version Oct 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (d86aa9a) to head (4414aa8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
+ Coverage     70.39%   70.46%   +0.06%     
  Complexity     1040     1040              
============================================
  Files           282      282              
  Lines         11312    11314       +2     
  Branches       1082     1030      -52     
============================================
+ Hits           7963     7972       +9     
+ Misses         2882     2875       -7     
  Partials        467      467              
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø) Carriedforward from ea6148c
kotlin 67.94% <ø> (+0.07%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@gusiri
Copy link
Contributor Author

gusiri commented Oct 8, 2024

I am looking at some errors:

run golangci-lint
  Running [/home/runner/golangci-lint-1.61.0-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=prover --timeout=5m] in [/runner/_work/linea-monorepo/linea-monorepo/prover] ...
  Error: could not import github.com/consensys/linea-monorepo/prover/zkevm/arithmetization (-: # github.com/consensys/linea-monorepo/prover/zkevm/arithmetization
  Error: zkevm/arithmetization/definition.go:90:20: corsetCS.String undefined (type "github.com/consensys/go-corset/pkg/schema".Constraint has no field or method String)
  Error: zkevm/arithmetization/definition.go:234:57: e.String undefined (type air.Expr has no field or method String)) (typecheck)
  Error: could not import github.com/consensys/linea-monorepo/prover/zkevm/arithmetization (-: # github.com/consensys/linea-monorepo/prover/zkevm/arithmetization
  Error: zkevm/arithmetization/definition.go:90:20: corsetCS.String undefined (type "github.com/consensys/go-corset/pkg/schema".Constraint has no field or method String)
  Error: zkevm/arithmetization/definition.go:234:57: e.String undefined (type air.Expr has no field or method String)) (typecheck)
  Error: : # github.com/consensys/linea-monorepo/prover/zkevm/arithmetization [github.com/consensys/linea-monorepo/prover/zkevm/arithmetization.test]
  Error: zkevm/arithmetization/definition.go:90:20: corsetCS.String undefined (type "github.com/consensys/go-corset/pkg/schema".Constraint has no field or method String)
  Error: zkevm/arithmetization/definition.go:234:57: e.String undefined (type air.Expr has no field or method String) (typecheck)

@AlexandreBelling
Copy link
Contributor

Is it the linter or also the whole compilation?

@gusiri gusiri linked an issue Oct 10, 2024 that may be closed by this pull request
3 tasks
@gusiri gusiri merged commit 37a2fb0 into main Oct 11, 2024
0 of 11 checks passed
@gusiri gusiri deleted the prover/bump-go-corset branch October 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go-corset code 77 error format
4 participants