fixed multi column #171
Merged
fixed multi column #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=========================================
Coverage 70.54% 70.54%
Complexity 1042 1042
=========================================
Files 282 282
Lines 11310 11310
Branches 1028 1080 +52
=========================================
Hits 7979 7979
Misses 2861 2861
Partials 470 470
|
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Soleimani193
force-pushed
the
prover/fix-lookup-multi-col-case
branch
from
63c2dee
to
efac362
Compare
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
AlexandreBelling
approved these changes
Oct 16, 2024
gusiri
approved these changes
Oct 17, 2024
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue regarding the lookup compiler.
the compiler was ignoring the multiColumn case, and only the first column was checked against the lookup table.
Checklist