Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add binary constraints for accumulators first lines #173

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

ivokub
Copy link
Contributor

@ivokub ivokub commented Oct 10, 2024

This PR fixes LA audit report Issue I.

In the ECPair module we have a column indicating if the current limb is the first line of the current or previous accumulator. As this is natively a boolean condition then we need to enforce it as a constraint to ensure the soundness in case of malicious prover.

Depends on #172. That one needs to be merged first and then the base branch of this one update to main.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@ivokub ivokub added bug Something isn't working Prover Tag to use for all work impacting the prover labels Oct 10, 2024
@ivokub ivokub self-assigned this Oct 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (9763bf2) to head (b330294).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #173   +/-   ##
=========================================
  Coverage     70.38%   70.38%           
  Complexity     1040     1040           
=========================================
  Files           282      282           
  Lines         11314    11314           
  Branches       1030     1030           
=========================================
  Hits           7963     7963           
  Misses         2880     2880           
  Partials        471      471           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 67.86% <ø> (ø) Carriedforward from 9763bf2

*This pull request uses carry forward flags. Click here to find out more.

Soleimani193
Soleimani193 previously approved these changes Oct 10, 2024
@ivokub ivokub changed the base branch from fix/audit-la-h-isactive-activation to main October 16, 2024 08:25
@ivokub ivokub dismissed Soleimani193’s stale review October 16, 2024 08:25

The base branch was changed.

@ivokub ivokub force-pushed the fix/audit-la-i-firstline-binary branch from abde94b to b330294 Compare October 16, 2024 08:45
@ivokub ivokub temporarily deployed to docker-build-and-e2e October 16, 2024 08:48 — with GitHub Actions Inactive
@ivokub ivokub merged commit 3c6219d into main Oct 16, 2024
25 checks passed
@ivokub ivokub deleted the fix/audit-la-i-firstline-binary branch October 16, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants