Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prover: apply the AVX optimizations for math/vector #185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prover: apply the AVX optimizations for math/vector #185

wants to merge 1 commit into from

Conversation

AlexandreBelling
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling self-assigned this Oct 15, 2024
gbotrel
gbotrel approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@gbotrel gbotrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; we can also kill the duplicate len checks on the vectors I believe (already done on gnark-crypto side)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel gbotrel approved these changes

@gusiri gusiri gusiri approved these changes

Assignees

@AlexandreBelling AlexandreBelling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreBelling @gbotrel @gusiri