Decompression Prover input padding and error handling #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabaie
added
bug
Tabaie
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=========================================
Coverage 70.36% 70.36%
Complexity 1040 1040
=========================================
Files 282 282
Lines 11309 11309
Branches 1080 1028 -52
=========================================
Hits 7958 7958
Misses 2880 2880
Partials 471 471
|
|
I tested it again with this fix, and it works now. Thank you so much for the quick fix! |
gusiri
approved these changes
Oct 15, 2024
|
@AlexandreBelling Could you please review this? |
gusiri
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
AlexandreBelling
approved these changes
Oct 16, 2024
gusiri
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During integration testing some proving requests were failing with an error claiming the blob checksum didn't match the one provided by the request.
This error was incorrectly reported because in fact the
assignfunction in the prover was failing. However before checking for a returned error, the backend first compared the returned "snark hash" (which was empty) with the given, correct one.The cause of the actual error was that the data fed into the prover was not the right length (128KB). The fix is for the prover to accept shorter blobs than the full size and pad them with zeros as needed.