Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson Serialiser and Deserialisers #194

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (f53e2d1) to head (55f8624).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/build/linea/s11n/jackson/ObjectMappers.kt 0.00% 21 Missing ⚠️
...n/kotlin/build/linea/s11n/jackson/BytesHexSerDe.kt 0.00% 8 Missing ⚠️
...kotlin/build/linea/s11n/jackson/NumbersHexSerDe.kt 0.00% 8 Missing ⚠️
...in/build/linea/s11n/jackson/InstantISO8601SerDe.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #194      +/-   ##
============================================
- Coverage     70.54%   70.16%   -0.39%     
+ Complexity     1042     1040       -2     
============================================
  Files           282      286       +4     
  Lines         11310    11349      +39     
  Branches       1028     1028              
============================================
- Hits           7979     7963      -16     
- Misses         2861     2918      +57     
+ Partials        470      468       -2     
Flag Coverage Δ *Carryforward flag
hardhat 98.69% <ø> (ø) Carriedforward from afe91f7
kotlin 67.64% <0.00%> (-0.41%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...in/build/linea/s11n/jackson/InstantISO8601SerDe.kt 0.00% <0.00%> (ø)
...n/kotlin/build/linea/s11n/jackson/BytesHexSerDe.kt 0.00% <0.00%> (ø)
...kotlin/build/linea/s11n/jackson/NumbersHexSerDe.kt 0.00% <0.00%> (ø)
...n/kotlin/build/linea/s11n/jackson/ObjectMappers.kt 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 17, 2024 13:18 — with GitHub Actions Inactive
@jpnovais jpnovais changed the title adds jackson Serialiser and Deserialisers Jackson Serialiser and Deserialisers Oct 17, 2024
@jpnovais jpnovais merged commit 74529e6 into main Oct 17, 2024
23 checks passed
@jpnovais jpnovais deleted the jvm-lib-json-rpc2-client branch October 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants