Use NatSpec for ITokenBridge events and errors #202
+172
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedarkjester
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=========================================
Coverage 70.69% 70.69%
Complexity 1059 1059
=========================================
Files 291 291
Lines 11972 11972
Branches 1106 1106
=========================================
Hits 8464 8464
Misses 3031 3031
Partials 477 477
|
thedarkjester
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
thedarkjester
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Julink-eth
reviewed
Oct 18, 2024
| event RemoteTokenBridgeSet(address indexed remoteTokenBridge, address indexed setBy); | ||
|
|
||
| /** | ||
| * @notice Emitted when the a token is set as deployed. |
| event TokenDeployed(address indexed token); | ||
|
|
||
| /** | ||
| * @notice Emitted when the a token deployment is confirmed. |
| event DeploymentConfirmed(address[] tokens, address indexed confirmedBy); | ||
|
|
||
| /** | ||
| * @notice Emitted when the a message service address is set. |
| event MessageServiceUpdated( | ||
| address indexed newMessageService, | ||
| address indexed oldMessageService, | ||
| address indexed setBy | ||
| ); | ||
|
|
||
| /** | ||
| * @dev Thrown when the attempting to bridge a reserved token. |
| error RemoteTokenBridgeAlreadySet(address remoteTokenBridge); | ||
|
|
||
| /** | ||
| * @dev Thrown when the attempting to reserve an already bridged token. |
| error NativeToBridgedTokenAlreadySet(address token); | ||
|
|
||
| /** | ||
| * @dev Thrown when trying to set a token is already either native, deployed or reserved. |
There was a problem hiding this comment.
"Thrown when trying to set a token that is already"
thedarkjester
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
count-sum
previously approved these changes
Oct 18, 2024
VGau
reviewed
Oct 18, 2024
VGau
previously approved these changes
Oct 18, 2024
VGau
approved these changes
Oct 18, 2024
VGau
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist