Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint block validation docs #1319

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Checkpoint block validation docs #1319

wants to merge 1 commit into from

Conversation

kpudlik
Copy link
Contributor

@kpudlik kpudlik commented Jul 29, 2020

No description provided.

of block - the hash should be different. If hash is different or does not match the content of block then such block
is rejected because is malformed.

## Balance validation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add info about double spend validation somewhere and a hint about blacklisting. If address performed a double spend it's actually being blacklisted forever (I think until rollback actually but Wyatt mentioned it was intended to be forever).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm not sure if double spend can be even performed at this point with checks we introduced in POST /transaction endpoint and pull for consensus logic. Still the check is there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe that's not a part of checkpoint block validation, but rather docs for checkpointAcceptanceService

If sum is bigger than current balance then address has `InsufficientBalance` and block is incorrect because
wallet has not enough tokens to send all the transactions from block.

### Staking amount validation (for node wallets)
Copy link
Contributor

@TheMMaciek TheMMaciek Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check is not really working. I remember that it will only work if a node processes it's own transaction, so in most cases it will not get triggered. So i'm not sure we should put it in docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants