-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint block validation docs #1319
base: dev
Are you sure you want to change the base?
Conversation
0fa67d0
to
1c0d5df
Compare
1c0d5df
to
77a5288
Compare
of block - the hash should be different. If hash is different or does not match the content of block then such block | ||
is rejected because is malformed. | ||
|
||
## Balance validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add info about double spend validation somewhere and a hint about blacklisting. If address performed a double spend it's actually being blacklisted forever (I think until rollback actually but Wyatt mentioned it was intended to be forever).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I'm not sure if double spend can be even performed at this point with checks we introduced in POST /transaction endpoint and pull for consensus logic. Still the check is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But maybe that's not a part of checkpoint block validation, but rather docs for checkpointAcceptanceService
If sum is bigger than current balance then address has `InsufficientBalance` and block is incorrect because | ||
wallet has not enough tokens to send all the transactions from block. | ||
|
||
### Staking amount validation (for node wallets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this check is not really working. I remember that it will only work if a node processes it's own transaction, so in most cases it will not get triggered. So i'm not sure we should put it in docs.
No description provided.