Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authorization webhook implementation and add tests #537

Merged
merged 5 commits into from
Oct 7, 2023
Merged

Conversation

tsipinakis
Copy link
Member

@tsipinakis tsipinakis commented Oct 7, 2023

Changes introduced with this PR

The authorization webhook had an incomplete implementation leading to it not functioning at all. Additionally, the configuration options were not in line with how it was documented, this PR fixes the webhook and brings the configuration option in line with the existing auth options

Previously:

  authz:
    method: webhook
    url: https://myauthenticationserver.example.org
    <webhook options>

Now:

  authz:
    method: webhook
    webhook: 
      url: https://myauthenticationserver.example.org
      <webhook options>

I'll merge this in a weeks time unless someone stops me for a review.

Additionally, add a code coverage job to our CI in order to spot some more blind spots like this.


By contributing to this repository, I agree to the contribution guidelines.

Signed-off-by: Nikos Tsipinakis <[email protected]>
Authz webhook configuration will now be placed under the 'webhook' key
to be in line with the other authentication methods.

Signed-off-by: Nikos Tsipinakis <[email protected]>
Signed-off-by: Nikos Tsipinakis <[email protected]>
@tsipinakis tsipinakis merged commit ad1233a into main Oct 7, 2023
5 checks passed
@tsipinakis tsipinakis deleted the fix_authz branch October 7, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants