Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit keyboardinteractive #563

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

tsipinakis
Copy link
Member

Changes introduced with this PR

Fixes keyboardinteractive authentication with audit log enabled. Previously the answers did not get correctly queried so they could be passed back to the sshserver.

I'll merge in 1 week unless someone stops me for a review.


By contributing to this repository, I agree to the contribution guidelines.

@tsipinakis tsipinakis added this to the 0.5.1 milestone Feb 15, 2024
@tsipinakis tsipinakis self-assigned this Feb 15, 2024
@tsipinakis tsipinakis force-pushed the fix_audit_keyboardinteractive branch 2 times, most recently from 8937d5a to e488e3b Compare February 15, 2024 18:00
@thmo
Copy link

thmo commented Feb 26, 2024

Just as a single data point, I was using this branch for a week now or so, and it seems to work well (besides ContainerSSH/ContainerSSH#587 maybe).

@tsipinakis tsipinakis force-pushed the fix_audit_keyboardinteractive branch 2 times, most recently from 66610b4 to 0c5cbae Compare March 4, 2024 19:57
@tsipinakis tsipinakis force-pushed the fix_audit_keyboardinteractive branch 2 times, most recently from 74d3a62 to 3f5be3f Compare May 14, 2024 04:59
tsipinakis and others added 2 commits May 14, 2024 07:16
The openid scope is required for the userinfo endpoint to work.

Signed-off-by: Nikos Tsipinakis <[email protected]>
@tsipinakis tsipinakis force-pushed the fix_audit_keyboardinteractive branch from 3f5be3f to 42da197 Compare May 14, 2024 05:16
@tsipinakis tsipinakis merged commit 84382d9 into main May 14, 2024
6 checks passed
@tsipinakis tsipinakis deleted the fix_audit_keyboardinteractive branch May 14, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants