Merge pull request #55 from ContainerSolutions/fix/exit-error

removing return condition on failed validation
ContainerSolutions · Jul 17, 2023 · 13134b2 · 13134b2
2 parents 97d699c + 45b4762
commit 13134b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -1,8 +1,6 @@
 name: deploy-image
 on:
-  push:
-    branches:
-      - main
+  workflow_dispatch: {}
 jobs:
     deploy:
         name: Release

diff --git a/operator/internal/provider/checkov/checkov.go b/operator/internal/provider/checkov/checkov.go
@@ -38,7 +38,7 @@ func (c *Client) Attest() (argusiov1alpha1.AttestationResult, error) {
 			RunAt:  v1.Now(),
 			Reason: fmt.Sprintf("could not get source repo for '%v'", c.RepoUrl),
 		}
-		return res, nil
+		return res, err
 	}
 
 	checkov_cmd := exec.Command("checkov", "-d", clone_location, "--check", c.Checks, "-o", "cli")
@@ -55,7 +55,6 @@ func (c *Client) Attest() (argusiov1alpha1.AttestationResult, error) {
 		res.Result = argusiov1alpha1.AttestationResultTypeUnknown
 		res.Err = err.Error()
 		res.Reason = "checkov execution returned error"
-		return res, err
 	}
 	if checkov_cmd.ProcessState.ExitCode() != 0 {
 		res.Result = argusiov1alpha1.AttestationResultTypeFail