Overhaul #12
Merged
Overhaul #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first, and most major step in a complete overhaul of thresher. The purpose of this is to support the current and near-future needs of scraperJSON, based on revisiting the design and incorporating a lot of user feedback. Major changes: - all scraping functionality has been moved to the Scraper class - the Thresher class now only handles selecting a scraper by URL, and running it - ScraperBox class holds a collection of scrapers and can match them to URLs - all logging has been removed and the entire module now operates using events scraperJSON features implemented: - elements can be nested (fixes #2 and ContentMine/scraperJSON#3) - elements can depend on 'following' the captured URLs from other elements (fixes #6) - URLs are resolved (and all redirects followed) before scraping (fixes #10) - headless pre-rendering is no longer default (for a massive speed/efficiency increase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first, and most major step in a complete overhaul of thresher.
The purpose of this is to support the current and near-future needs of
scraperJSON, based on revisiting the design and incorporating a lot of
user feedback.
Major changes:
scraperJSON features implemented: