Debug_12/15/24 #215
Open
Debug_12/15/24 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data and line 232 replaced bo.get_data().T with bo.data.T: on helpers.py
…0 replaced is with ==
lucywowen
reviewed
Dec 23, 2024
There was a problem hiding this comment.
@jeremymanning I'm not sure if these are just changes @joseJCS0 needed to make to get this to run.... can you take a look at this to see if we should merge this? I'm referring to the file location changes.
|
I don't have time to dig into this-- but @lucywowen once you've tested this code and are convinced it works, I'm fine for us to merge it! |
|
(from a quick skim all of these changes look reasonable to me...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.