Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_agent_data_from_coord_iter to allow no agents on the grid #13

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Update get_agent_data_from_coord_iter to allow no agents on the grid #13

merged 1 commit into from
Dec 14, 2023

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Dec 14, 2023

Allows models on which not all cells contain an agent.

Closes #12.

Confirmed it solved the problem:

Screenshot_310

@Corvince Corvince merged commit 4a102a9 into Corvince:main Dec 14, 2023
1 check passed
@EwoutH
Copy link
Contributor Author

EwoutH commented Dec 23, 2023 •
edited
Loading

I think I accidentally broke something in this PR, because now the forest fire example errors:

Screenshot_321

@EwoutH EwoutH mentioned this pull request Dec 23, 2023
Merged
@EwoutH
Copy link
Contributor Author

EwoutH commented Dec 23, 2023

Fixed in #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corvince Corvince Corvince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError in get_agent_data_from_coord_iter when not all grid cells contain agents
2 participants
@EwoutH @Corvince