Optionally allow overwriting of the hooks file name #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-gora
commented
Oct 11, 2021
| @@ -175,11 +183,15 @@ private String preCommitHookBaseScriptCall() { | |||
| return calls; | |||
| } | |||
|
|
|||
| private String getHookScriptName() { | |||
| return Optional.ofNullable(this.hookScriptName).orElseGet(this::artifactId); | |||
There was a problem hiding this comment.
this is the actual change introduced.
|
Please remove any change (formatting, final keyword addition, ...) that does not directly pertain to the goal of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of my teams my colleagues discovered a problem:
If you run a multi-module project, the script initializes a hook for each module which you might have executed.
E.g. if you ran the project on root level, but at a later time only a sub module, to save some time compiling and testing...
This means the check will be executed for each module which had a maven run beforehand.
In order to circumvent that, a configuration option where you'd be able to override the generated script's name would be beneficial.
I provided a PR adding a config option which will be taken in favour of the artifactId if it is set.
Additionally I formatted the code with the google formatter ;)