Fix type information when using dynamic projection and generic repository #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reda-alaoui
force-pushed
the
fix-type-information
branch
from
72fae93
to
85988a6
Compare
|
Hello @leassis , |
|
Do you have a standard formatter? |
|
done! |
reda-alaoui
requested changes
Dec 26, 2023
There was a problem hiding this comment.
Everything looks fine to me.
But this introduces a breaking change regarding the support of Spring Data JPA. Therefore, the README's Compatibility matrix (https://github.com/Cosium/spring-data-jpa-entity-graph?tab=readme-ov-file#compatibility-matrix) should be changed to show that:
- Spring Data JPA
3.2.1+is supported by Spring Data JPA Entity Graph3.2.2+ - Spring Data JPA
3.2.0is supported by Spring Data JPA Entity Graph3.2.0-3.2.1
reda-alaoui
changed the title
reda-alaoui
requested changes
Dec 27, 2023
reda-alaoui
approved these changes
Dec 27, 2023
|
Thank you @leassis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: the type information when using generic repository along with dynamic projections.
closes #148