Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return List instead of Iterable and adapt to new interface-hierarchy #202

Closed
wants to merge 1 commit into from

Conversation

fladdimir
Copy link

proposal for resolving #201

@fladdimir fladdimir marked this pull request as ready for review July 31, 2024 22:21
@fladdimir fladdimir marked this pull request as draft July 31, 2024 22:21
@fladdimir fladdimir marked this pull request as ready for review August 27, 2024 23:03
@reda-alaoui
Copy link
Member

Hi @fladdimir ,
Sorry for the time it took me to take a look. I am ok with your changes but we need to have a migration window.

Would it be possible to not touch the current repository interfaces, and create new ones in a new repository2 package?

I want people to migrate incrementally if needed, by exposing 2 repository trees (the deprecated one and yours), until the next Spring major version.

@reda-alaoui reda-alaoui self-requested a review August 29, 2024 14:23
Copy link
Member

@reda-alaoui reda-alaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@fladdimir
Copy link
Author

Hi @reda-alaoui, Thank you for the feedback!
I fully understand that the major version numbers should be kept in sync and thus a breaking change is not possible at the moment.
As the proposed change does not provide much functionality, it is probably not worth to introduce a whole new repository(2) interface tree / package?
As long as nothing more important/useful comes up, it might just be simpler to wait for the next spring-data-jpa major release?

@fladdimir fladdimir closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants