forked from spring-projects/spring-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support parameter injection in @[Before|After]Transaction methods
Prior to this commit, @BeforeTransaction and @AfterTransaction methods could not accept any arguments. This is acceptable with testing frameworks such as JUnit 4 and TestNG that do not provide support for parameter injection. However, users of JUnit Jupiter have become accustomed to being able to accept arguments in lifecycle methods annotated with JUnit's @BeforeEach, @AfterEach, etc. As a follow up to the previous commit (see spring-projectsgh-31199), this commit introduces first-class support for parameter injection in @BeforeTransaction and @AfterTransaction methods, as demonstrated in the following example. @BeforeTransaction void verifyInitialDatabaseState(@Autowired DataSource dataSource) { // Use the DataSource to verify the initial DB state } Closes spring-projectsgh-30736
- Loading branch information
Showing
6 changed files
with
187 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
.../context/junit/jupiter/transaction/TransactionLifecycleMethodParameterInjectionTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Copyright 2002-2023 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.test.context.junit.jupiter.transaction; | ||
|
|
||
| import javax.sql.DataSource; | ||
|
|
||
| import org.junit.jupiter.api.AfterAll; | ||
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.TestInfo; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.context.ApplicationContext; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.jdbc.datasource.DataSourceTransactionManager; | ||
| import org.springframework.jdbc.datasource.embedded.EmbeddedDatabaseBuilder; | ||
| import org.springframework.test.context.junit.jupiter.SpringJUnitConfig; | ||
| import org.springframework.test.context.transaction.AfterTransaction; | ||
| import org.springframework.test.context.transaction.BeforeTransaction; | ||
| import org.springframework.transaction.annotation.Transactional; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.springframework.test.transaction.TransactionAssert.assertThatTransaction; | ||
|
|
||
| /** | ||
| * JUnit Jupiter based integration tests which verify support for parameter | ||
| * injection in {@link BeforeTransaction @BeforeTransaction} and | ||
| * {@link AfterTransaction @AfterTransaction} lifecycle methods. | ||
| * | ||
| * @author Sam Brannen | ||
| * @since 6.1 | ||
| */ | ||
| @SpringJUnitConfig | ||
| class TransactionLifecycleMethodParameterInjectionTests { | ||
|
|
||
| static boolean beforeTransactionInvoked = false; | ||
| static boolean afterTransactionInvoked = false; | ||
|
|
||
|
|
||
| @BeforeAll | ||
| static void checkInitialFlagState() { | ||
| assertThat(beforeTransactionInvoked).isFalse(); | ||
| assertThat(afterTransactionInvoked).isFalse(); | ||
| } | ||
|
|
||
| @BeforeTransaction | ||
| void beforeTransaction(TestInfo testInfo, ApplicationContext context, @Autowired DataSource dataSource) { | ||
| assertThatTransaction().isNotActive(); | ||
| assertThat(testInfo).isNotNull(); | ||
| assertThat(context).isNotNull(); | ||
| assertThat(dataSource).isNotNull(); | ||
| beforeTransactionInvoked = true; | ||
| } | ||
|
|
||
| @Test | ||
| @Transactional | ||
| void transactionalTest(TestInfo testInfo, ApplicationContext context, @Autowired DataSource dataSource) { | ||
| assertThatTransaction().isActive(); | ||
| assertThat(testInfo).isNotNull(); | ||
| assertThat(context).isNotNull(); | ||
| assertThat(dataSource).isNotNull(); | ||
| assertThat(beforeTransactionInvoked).isTrue(); | ||
| assertThat(afterTransactionInvoked).isFalse(); | ||
| } | ||
|
|
||
| @AfterTransaction | ||
| void afterTransaction(TestInfo testInfo, ApplicationContext context, @Autowired DataSource dataSource) { | ||
| assertThatTransaction().isNotActive(); | ||
| assertThat(testInfo).isNotNull(); | ||
| assertThat(context).isNotNull(); | ||
| assertThat(dataSource).isNotNull(); | ||
| afterTransactionInvoked = true; | ||
| } | ||
|
|
||
| @AfterAll | ||
| static void checkFinalFlagState() { | ||
| assertThat(beforeTransactionInvoked).isTrue(); | ||
| assertThat(afterTransactionInvoked).isTrue(); | ||
| } | ||
|
|
||
|
|
||
| @Configuration | ||
| static class Config { | ||
|
|
||
| @Bean | ||
| DataSourceTransactionManager transactionManager(DataSource dataSource) { | ||
| return new DataSourceTransactionManager(dataSource); | ||
| } | ||
|
|
||
| @Bean | ||
| DataSource dataSource() { | ||
| return new EmbeddedDatabaseBuilder().generateUniqueName(true).build(); | ||
| } | ||
| } | ||
|
|
||
| } |