Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom msg support #179

Merged
merged 11 commits into from
Jun 27, 2023
Merged

Custom msg support #179

merged 11 commits into from
Jun 27, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Jun 16, 2023

close #157

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #179 (0fbb83b) into main (32e783a) will increase coverage by 0.32%.
The diff coverage is 76.69%.

❗ Current head 0fbb83b differs from pull request most recent head 2552d5f. Consider uploading reports for the commit 2552d5f to get more accurate results

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   76.32%   76.64%   +0.32%     
==========================================
  Files          22       22              
  Lines        1098     1126      +28     
==========================================
+ Hits          838      863      +25     
- Misses        260      263       +3     
Impacted Files Coverage Δ
sylvia-derive/src/message.rs 74.48% <59.37%> (-1.83%) ⬇️
sylvia-derive/src/multitest.rs 76.56% <70.00%> (+1.82%) ⬆️
sylvia-derive/src/parser.rs 81.57% <75.00%> (+0.77%) ⬆️
sylvia-derive/src/input.rs 81.57% <82.35%> (-3.36%) ⬇️
sylvia-derive/src/lib.rs 73.91% <100.00%> (-1.09%) ⬇️
sylvia-derive/src/strip_input.rs 91.42% <100.00%> (+1.10%) ⬆️
sylvia/tests/custom_msg.rs 100.00% <100.00%> (+75.00%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the custom_msg_support branch 2 times, most recently from 909e423 to 94982b1 Compare June 16, 2023 14:28
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashedone hashedone merged commit a93ce20 into main Jun 27, 2023
@hashedone hashedone deleted the custom_msg_support branch June 27, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom chain messages on sylvia contracts
2 participants