Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New type SudoCtx #192

Merged
merged 1 commit into from
Jul 14, 2023
Merged

feat: New type SudoCtx #192

merged 1 commit into from
Jul 14, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Jul 7, 2023

Part of #189

@jawoznia jawoznia requested a review from hashedone July 7, 2023 10:42
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #192 (d71c5a6) into entry_points_overriding (95024bc) will increase coverage by 0.53%.
The diff coverage is 0.00%.

@@                     Coverage Diff                     @@
##           entry_points_overriding     #192      +/-   ##
===========================================================
+ Coverage                    82.95%   83.48%   +0.53%     
===========================================================
  Files                           23       23              
  Lines                         1185     1175      -10     
===========================================================
- Hits                           983      981       -2     
+ Misses                         202      194       -8     
Impacted Files Coverage Δ
sylvia/src/types.rs 25.00% <0.00%> (-5.77%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a full feat so I would prefer it to be done with the usage, but besides that LGTM

@jawoznia jawoznia merged commit f0ac1d4 into entry_points_overriding Jul 14, 2023
@jawoznia jawoznia deleted the sudoctx_type branch July 14, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants