fix!: Remote type implements all relevant traits so it can be stored in #[cw_serde] types
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in `#[cw_serde]` types
Codecov Report
@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 82.95% 83.70% +0.74%
==========================================
Files 23 23
Lines 1185 1172 -13
==========================================
- Hits 983 981 -2
+ Misses 202 191 -11
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hashedone
changed the title
Remote type implements all relevant traits so it can be stored in #[cw_serde] typesRemote type implements all relevant traits so it can be stored in #[cw_serde] types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #181
BREAKING CHANGE: new traits are generated on the
Remotetype:Clone,Debug,PartialEq,schemars::JsonSchema. If any traits with functions of the same signature as one of added traits are implemented manually on theRemotetype (eg.:fn clone()), it might break compilation. It is very unlikely case, but technically possible.