Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Override generated entry_points #197

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat: Override generated entry_points #197

merged 1 commit into from
Jul 25, 2023

Conversation

jawoznia
Copy link
Collaborator

closes #189

@jawoznia jawoznia requested a review from hashedone July 19, 2023 14:17
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (entry_points_overriding@7ff3d97). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             entry_points_overriding     #197   +/-   ##
==========================================================
  Coverage                           ?   82.82%           
==========================================================
  Files                              ?       24           
  Lines                              ?     1304           
  Branches                           ?        0           
==========================================================
  Hits                               ?     1080           
  Misses                             ?      224           
  Partials                           ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the override_entry_points_generation branch 2 times, most recently from 55650b8 to 88b217f Compare July 20, 2023 08:51
hashedone
hashedone approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK, but don't bumb the version - we want to make it so CI does it properly on release PR.

examples/Cargo.toml Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the override_entry_points_generation branch 2 times, most recently from 3c23167 to 63694f5 Compare July 25, 2023 11:41
@jawoznia jawoznia merged commit 212cc63 into entry_points_overriding Jul 25, 2023
7 checks passed
@jawoznia jawoznia deleted the override_entry_points_generation branch July 25, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone