Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove version from workspace sylvia-derive dependency #198

Closed
wants to merge 2 commits into from

Conversation

jawoznia
Copy link
Collaborator

Motivation

Release-plz didn't update workspace-dependencies. Tried also to add workspace-dependency for cosmwasm-std but with no success.

Workaround

We can remove sylvia-derive version from deps and rely solely on path. In future we should come up with solution to automatize workspace dependencies update and migrate shared dependencies to workspace Cargo.toml

@jawoznia jawoznia requested a review from hashedone July 20, 2023 11:52
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #198 (9303f53) into main (5b9f247) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          23       23           
  Lines        1172     1172           
=======================================
  Hits          981      981           
  Misses        191      191           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hashedone
Copy link
Collaborator

Why is that? DIdn't we want to move version entirely to per-project cargo?

@jawoznia
Copy link
Collaborator Author

Why is that? DIdn't we want to move version entirely to per-project cargo?

You mean workspace cargo?
I made this change because version in workspace.dependency is not updated. For now it might be a WA.

@jawoznia
Copy link
Collaborator Author

After offline talk agree this would damage crates.io release

@jawoznia jawoznia closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants